(documentation) List of mistakes

Hi,

In the new documentation’s version of the component, I have picked out some mistakes.

Here the list (I will add replies with possible new ones, as one goes along) :

onEventAdded
void onEventAdded(string id, event e){ … };
(Mistake) 2nd param must be : object ev

onEventChanged
void onEventChanged(string id, event e){ … };
(Mistake) 2nd param must be : object ev

onEventAdded
void onEventAdded(string id, event e){ … };
(Mistake) 2nd param must be : object ev

onEventLoading
void onEventLoading(object data){ … };
(Mistake) 2nd param must be : object ev

Regards,

Thanks for the corrections! Will review the list and update the articles in the nearest time

Hi Aliaksandr,

You’re welcome !

I keep on with a new list, and hope I’m not wrong or waste your time.

1/
onBeforeEventChanged
void onBeforeEventChanged(object ev, event e, flag, object ev_old){ … };
(Mistake) ev_old seems to be never set
@see in scheduler._on_mouse_up=function(e){}
in line : if (!this.callEvent(“onBeforeEventChanged”,[ev, e, is_new])){

2/
docs.dhtmlx.com/scheduler/api__s … plate.html

void event_class(Date start, Date end, object event){ … };
Example : function(start,end,ev){

Maybe a look at the whole documentation would be great to “harmonize” names.
Eg: “ev” instead of “event” and “event_object”

Other examples : scheduler.templates.event_bar_date = function(start,end,ev); (with ev) or docs.dhtmlx.com/scheduler/api__s … plate.html (with ‘event’)

3/
docs.dhtmlx.com/scheduler/api__s … event.html
onEventLoading
void onEventLoading(object data){ … };
Mistake : return bool instead of void

4/
docs.dhtmlx.com/scheduler/api__s … event.html
onBeforeEventChanged
void onBeforeEventChanged(object ev, event e, flag, object ev_old){ … };
Mistake : return bool instead of void

5/
docs.dhtmlx.com/scheduler/api__s … plate.html
event_class
void event_class(Date start, Date end, object event){ … };
Mistake : return string instead of void
Idem for functions : event_header

6/
“filter_month” is not found in search engine (filter_week is).

7/
docs.dhtmlx.com/scheduler/custom_views.html
In :
3. To define the method that will return the start date of the view interval, i.e. Monday of the active week:
scheduler.date.workweek_start = functuin(date) {
scheduler.date.week_start(date);//
}

8/
Two mistakes :
1/ functuin vs function
2/ “scheduler.date.week_start(date);” need to be returned, else function result can not be processed. Two ways exist with this method (because “scheduler.date.week_start” already exist, by default), so :

  • either use “return scheduler.date.week_start(date);”
  • either do not put instruction in anonymous function and use directly : “scheduler.date.workweek_start = scheduler.date.week_start:”

I keep on with demos :

1/
In : docs.dhtmlx.com/scheduler/sample … usage.html
The JS relative to locale (ES) is not found : …/…/sources/locale/locale_es.js

2/
In : docs.dhtmlx.com/scheduler/sample … om_db.html
Combo is not populated by server-side values

3/
In : docs.dhtmlx.com/scheduler/sample … ssage.html
After clicking on “revert event”, the event stays at this position : no effect ?

4/
In : docs.dhtmlx.com/scheduler/sample … index.html
“Keabord navigation in the scheduler” should be “Keyboard […]”

5/
In : docs.dhtmlx.com/scheduler/sample … index.html
For both "Hiding hours while displaying several weeks in Week view " and “Marker of hidden days while displaying several weeks in Week view”, would it not be “[…] in Timeline view” ?

6/
Mistake or not ?

In : docs.dhtmlx.com/scheduler/sample … _view.html
Map view seems not to display the 1st Sep 2010 event, contraty to the other demo realtive to map : docs.dhtmlx.com/scheduler/sample … rames.html

7/
In : docs.dhtmlx.com/scheduler/sample … hours.html
“Custom navigation through the time scale (X-Axis)” seems not to be implemented

8/
In : docs.dhtmlx.com/scheduler/custom … ntent.html
“scheduler.templates.event_date(end);” at the end of the condition “if (event.important == true){”

Eureka75, thank you for your post. We have taken it into careful consideration and corrected the mistakes you have found.

We really appreciate the work you have done and hope to see your other comments and suggestions that will help us to improve our documentation and demos.