error in dhtmlxgrid_excell_dhxcalendar.js

Suite and Optimus Suite 5
#1

//v.2.6 build 100722
Line 143 (from file in /sources directory) function eXcell_dhxCalendarA says:

this.grid.callEvent(“onDhxCalendarCreated”,[cal]);

However var cal has not been defined as it was in function eXcell_dhxCalendar (line 19)
line 135 should say:
var cal=this.grid._grid_calendarA=new dhtmlxCalendarObject(z,false, {isYearEditable :true} );

#2

Can you provide code snipped were we can reproduce this issue?

#3

Its a code error that I found while initiating a grid with XML and the CalenderA control.
You don’t need code snippets, just look at the function eXcell_dhxCalendar and the way in which the calendar object is created (using a variable) and the function eXcell_dhxCalendarA where the variable is absent.

However the code in both saysl: this.grid.callEvent(“onDhxCalendarCreated”,[cal]);
but in the second function the lack of a the ‘cal’ variable causes the function to fail.

#4

To fix this issue try to update your dhtmlxgrid_excell_dhxcalendar.js file with file from attachment
dhtmlxgrid_excell_dhxcalendar.zip (1.98 KB)

#5

Thanks but I seem to have found other things and I’d rather fix them as I go (like changing the default date format to m/d/y in the demo code).

You might want to look in Grid and Dataprocessor for “onValidatationError” instead of “onValidationError” as per the documentation (which needs some work too).

I’m finding a lot of questionable code that I can see using Firefox Error Console.
I lot of CSS and javascript errors showing up just as I browse this site.
E.g.
Warning: variable oldObj redeclares argument
Source File: dhtmlx.com/js/dhtmlxcommon.js?v=90904
Line: 99, Column: 6
Source Code:
var oldObj = this.xmlDoc;

Warning: anonymous function does not always return a value
Source File: dhtmlx.com/js/dhtmlxcommon.js?v=90904
Line: 337, Column: 9
Source Code:
return false;

These above appear harmless, but I’m a bit worried about the level of testing done with these controls. Have they been heavily vetted using firefox or just IE?

I really like most of what has been done however, its just a question of should my corporation use jquery based controls or dhtmlx.