Is there anything wrong or error will be occurred after modi

Discontinued products Uncategorized discussions
#1


Hi team



The original method in the dhtmlxcombo.js is like this.



dhtmlXCombo.prototype.selectOption = function(ind,filter,conf){
        if (arguments.length<3) conf=true;
         this.unSelectOption();



         �� 




          /Event/
         this.callEvent(“onSelectionChange”,[]);
 }



If I modified the mothod like this , Is there anything wrong or error will be occurred after modified it ?



dhtmlXCombo.prototype.selectOption = function(ind,filter,conf){



          /Event/
         this.callEvent(“onSelectionChange”,[]);




        if (arguments.length<3) conf=true;
         this.unSelectOption();



        �� 
 }



thanks.

#2

It will not cause any side effects
onSelectionChange event not used in inner logic ( it made for custom code only ) , so you can freely change its position in code or fully remove it without any consequences

#3

Thanks a lot.