Should not touch the document.body node while DnDing


#1

image

I think dhtmlx-gantt should not modify document.body node while dragging a node inside the dhtmlx-gantt widget, because it would decrease the performance, if you need, you should modify parent node of dhtmlx-gantt widget.


#2

Hi Kevin,

Were you able to see or measure a performance effect of this code?
Right now I don’t think there will be any measurable effect if we change or remove that code since dragStart is called only once per drag and drop action. As long as there are no heavy operations that could freeze the screen or create noticeable input lag, I’d expect any optimizations here to have pretty negligible effect.

But I agree that modifying document.body here doesn’t seem necessary, I’ll add a note to change it at some point.

Thanks!


#3

Thanks Aliaksadr ~~ ~